Conversation
|
Thanks for the PR. Could you git rebase it? It looks like it now changes a lot, which it probably doesn't. |
Hi! I'm new to using Git. I've rebased the branch. The diff only contains the single networkx line addition to requirements.txt. Let me know if anything else is needed! |
|
For some reason 3 other commits are included. I normally sync the upstream |
|
Hey! Reviewed this PR 👋 git remote add upstream https://github.com/projectmesa/mesa-examples
git fetch upstream
git rebase upstream/main
git push --force-with-lease origin fix-forest-fire-networkx-dependencyOnce that's sorted the PR should be good to merge! Happy to take another look after the rebase 🙂 |
GITUSERMANOLYA
force-pushed
the
fix-forest-fire-networkx-dependency
branch
from
75cc3e8 to
af11d84
Compare
GITUSERMANOLYA
force-pushed
the
fix-forest-fire-networkx-dependency
branch
from
af11d84 to
0a5c212
Compare
|
Done! Rebased onto upstream/main. The diff now shows only the single +networkx line addition.Thanks for the help!! EwoutH and Harshini2411! |
| @@ -1,2 +1,3 @@ | |||
| jupyter | |||
| mesa[viz]>=3.0 | |||
| networkx | |||
There was a problem hiding this comment.
Added networkx as it was missing from requirements.txt, which caused a ModuleNotFoundError when running the forest_fire example.
|
Looks good now! The rebase is clean, diff is exactly the one line it should be, and the fix is correct. LGTM and ready to merge! 🙌 |
|
I see forest_fire is based on Grid then why do we need networkx as dependency? Am I missing something? |
4 participants
GSoC contributor checklist
Context & motivation
I am a beginner in open source, I went through many organizations and picked this particular organization and this particular project as it is simple and aligned with the skills I am good at.I was exploring the mesa-examples repository as part of my GSoC 2026 application for the Mesa Examples Revival project. I ran all 22 examples to understand the current state of the repo. When I ran the forest_fire example, I got a ModuleNotFoundError for networkx. I checked the requirements.txt and networkx was missing, so I added it.
What I learned
I learned how Python dependency management works with requirements.txt. I also learned how to use git rebase to clean up a PR branch, and how the GitHub PR review process works. This was my first open source contribution. I am polishing my basic knowledge of git commands. This gave me an exciting opportunity to learn and explore more of git and github and open source projects
Learning repo
🔗 My learning repo: https://github.com/GITUSERMANOLYA/GSoC-learning-space
🔗 Relevant model(s): N/A
Readiness checks